Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 668 #693

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Gh 668 #693

merged 1 commit into from
Jul 3, 2024

Conversation

R-Lawton
Copy link
Contributor

@R-Lawton R-Lawton commented Jun 9, 2024 •
edited
Loading

Verification

export KUADRANT_ORG=R-Lawton 
export KUADRANT_REF=gh-668 
hack/quickstart-setup.sh
  • Port forward grafana
    kubectl -n monitoring port-forward svc/grafana 3000:3000
  • Ensure the 2 dashboards get deployed
  • controller runtime
    Screenshot 2024-07-02 at 17 38 52
    controller-resources
    Screenshot 2024-07-02 at 17 33 56

@R-Lawton R-Lawton marked this pull request as ready for review July 2, 2024 16:51
@R-Lawton R-Lawton requested a review from a team as a code owner July 2, 2024 16:51
@david-martin
Copy link
Contributor

👀

@david-martin
Copy link
Contributor

david-martin commented Jul 3, 2024 •
edited
Loading

/lgtm
/approve

Verified locally.
Dashboards loaded OK and render data.

I did notice a potential bug in one of the panels, but I'll chase that up in the original dashboard source repo.
EDIT: kubernetes-sigs/kubebuilder#4000

@R-Lawton R-Lawton force-pushed the gh-668 branch 2 times, most recently from aa411eb to 145847e Compare July 3, 2024 13:59
@R-Lawton
Adding in grafana kubebuilder plugin for limitador, kuadrant and auth…
1f348f6 
…orino operator metrics. also rejiged observability folder structure for ease of readability and because there was a bug that the service monitors were not being created
@R-Lawton R-Lawton merged commit a52b8d9 into Kuadrant:main Jul 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-martin david-martin david-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R-Lawton @david-martin